Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10235): Play/Pause button is not accurately centered in small player #519

Merged
merged 4 commits into from
Jun 25, 2020
Merged

fix(FEC-10235): Play/Pause button is not accurately centered in small player #519

merged 4 commits into from
Jun 25, 2020

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jun 23, 2020 •
edited

Description of the Changes

Since #398.
Use transform: translate(-50%, -50%) and white-space: nowrap insteadof hardcoded margin

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team June 23, 2020 12:06
@yairans yairans self-assigned this Jun 23, 2020
@yairans yairans changed the title fix(FEC-10235): Play/Pause button is not accurately centered fix(FEC-10235): Play/Pause button is not accurately centered in small player Jun 23, 2020
@yairans yairans closed this Jun 23, 2020
@yairans yairans reopened this Jun 23, 2020
@yairans yairans closed this Jun 23, 2020
@yairans yairans reopened this Jun 23, 2020
@yairans yairans merged commit f2f608f into master Jun 25, 2020
@yairans yairans deleted the FEC-10235 branch June 25, 2020 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe left review comments

@dan-ziv dan-ziv dan-ziv approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yairans @OrenMe @dan-ziv