Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10052): the bottom toolbar not hiding after return from background on mobile devices #523

Merged
merged 3 commits into from
Jun 30, 2020
Merged

fix(FEC-10052): the bottom toolbar not hiding after return from background on mobile devices #523

merged 3 commits into from
Jun 30, 2020

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Jun 30, 2020

Description of the Changes

Always update the hover state after player transition from paused to playing, whether it's caused by returning from background on mobile or by an API call.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv requested a review from a team June 30, 2020 06:36
@dan-ziv dan-ziv self-assigned this Jun 30, 2020
OrenMe
OrenMe previously approved these changes Jun 30, 2020
View reviewed changes
@dan-ziv dan-ziv merged commit 87bd41e into master Jun 30, 2020
@dan-ziv dan-ziv deleted the FEC-10052 branch June 30, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans requested changes

@OrenMe OrenMe OrenMe left review comments

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dan-ziv @OrenMe @yairans