Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-10226): captions menu doesn't close with keyboard navigation in a small player #525

Merged
merged 2 commits into from
Jul 23, 2020

Conversation

RoyBregman
Copy link
Contributor

Description of the Changes

Bug happens due to focus in the unmount of the KeyBoardAccessibility HOC which occurs before the key event bubbling is done.

  • renamed onControlButtonClick to toggleSmartContaierOpen in language.js
  • added preventDefault on the key 'enter' to fix the bug and avoid bubbling to the language toggle button
  • fixed previouslyActiveElement so it stores only if an auto focus was done and not always - for example - in the languages the menus inside also kept the previous element (which is the same language toggle button) and when the languages were close the button was focused 4 times instead of once

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@RoyBregman RoyBregman requested review from OrenMe, dan-ziv, yairans and Yuvalke and removed request for OrenMe July 6, 2020 09:31
@OrenMe OrenMe changed the title fix(FEC-10226): in a small player in the captions menu ,menu doesn't close with keyboard navigation fix(FEC-10226): captions menu doesn't close with keyboard navigation in a small player Jul 6, 2020
@RoyBregman RoyBregman merged commit d0f815d into master Jul 23, 2020
@RoyBregman RoyBregman deleted the FEC-10226-close-button branch July 23, 2020 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants