feat(FEC-9951): pip play here #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyBregman
requested review from
yairans,
dan-ziv,
OrenMe and
Yuvalke
and removed request for
yairans
OrenMe
reviewed
Jul 7, 2020
OrenMe
reviewed
Jul 7, 2020
OrenMe
approved these changes
Jul 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
As play here button in the PIP overlay was hidden under the play / pause overlay buttons when in small screens / mobile - We decided (together with Ron L and Hillel C) to remove the "Play here" button and relocate the title in the first quarter of the player instead of the center.
In addition, to make the UX more clear - the PIP button in the bottom bar has now a new state to expand back.
solves FEC-9951
CheckLists