Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-10057): move the plugin manager to kaltura player #529

Merged
merged 7 commits into from
Aug 5, 2020

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jul 19, 2020

Description of the Changes

import types from kaltura-player

Solves FEC-10057

Related to kaltura/kaltura-player-js#332

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team July 23, 2020 08:58
@yairans yairans self-assigned this Jul 23, 2020
Yuvalke
Yuvalke previously approved these changes Aug 5, 2020
package.json Outdated
@@ -39,7 +39,7 @@
"redux": "^3.6.0"
},
"devDependencies": {
"@playkit-js/playkit-js": "^0.59.5",
"kaltura-player-js": "https://github.com/kaltura/kaltura-player-js.git#FEC-10057",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember to change it before merge

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and remove dist

@yairans yairans merged commit 167726a into master Aug 5, 2020
@yairans yairans deleted the FEC-10057 branch August 5, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants