fix(FEC-10326): customPreset breaks UI #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial shell mounting is happening after external preset mounts and in tooltips we rely on the shell prop isMobile. As this is one time decision we can update it in the initial state. Also refactor our with animation innerRef to avoid passing new anonymous function every time
yairans
previously approved these changes
Jul 21, 2020
yairans
approved these changes
Jul 21, 2020
Yuvalke
pushed a commit
that referenced
this pull request
Jul 27, 2020
The initial shell mounting is happening after external preset mounts and in tooltips we rely on the shell prop isMobile. As this is one time decision we can update it in the initial state. Also refactor our with animation innerRef to avoid passing new anonymous function every time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
The initial shell mounting is happening after external preset mounts and in tooltips we rely on the shell prop isMobile.
As this is one time decision we can update it in the initial state.
Also refactor our with animation innerRef to avoid passing new anonymous function every time
CheckLists