Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10524): stub logger and get logger from Kaltura player. #547

Merged
merged 10 commits into from
Oct 5, 2020
Merged

fix(FEC-10524): stub logger and get logger from Kaltura player. #547

merged 10 commits into from
Oct 5, 2020

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Sep 29, 2020

Description of the Changes

Issue: we bundling a few js-logger on Kaltura player.
Solution: get logger from Kaltura player and add stub whenever we don't get it from Kaltura player.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke
feat: stub logger and get logger from kaltura player.
248cd64 
Issue: we bundling few js-logger.
Solution: get logger from kaltura player and add stub whenever we don't get it from kaltura player.
@Yuvalke Yuvalke requested a review from a team September 29, 2020 10:19
@Yuvalke Yuvalke self-assigned this Sep 29, 2020
OrenMe
OrenMe requested changes Sep 29, 2020
View reviewed changes
src/ui-manager.js Outdated Show resolved Hide resolved
@Yuvalke Yuvalke changed the title fix: stub logger and get logger from Kaltura player. fix(FEC-10524): stub logger and get logger from Kaltura player. Sep 30, 2020
@Yuvalke Yuvalke merged commit e1196e3 into master Oct 5, 2020
@Yuvalke Yuvalke deleted the stub-logger branch October 5, 2020 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe requested changes

Assignees

@Yuvalke Yuvalke

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Yuvalke @OrenMe