Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10526): iPad iOS11 - wrong full screen button state when PiP active #548

Merged
merged 3 commits into from
Oct 18, 2020
Merged

fix(FEC-10526): iPad iOS11 - wrong full screen button state when PiP active #548

merged 3 commits into from
Oct 18, 2020

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Sep 30, 2020 •
edited

Description of the Changes

Issue: iOS < 13 doesn't fire EXIT_FULLSCREEN when moving from native full screen (AV player) to PiP
Solution: Update the button state using PRESENTATION_MODE_CHANGED event

Solves FEC-10526

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team September 30, 2020 22:11
@yairans yairans merged commit 3bab3b7 into master Oct 18, 2020
@yairans yairans deleted the FEC-10526 branch October 18, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@Yuvalke Yuvalke Yuvalke approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yairans @OrenMe @Yuvalke