Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10481): "advertisement" title displays during bumper, when using new ad layout #555

Merged
merged 1 commit into from Nov 1, 2020
Merged

fix(FEC-10481): "advertisement" title displays during bumper, when using new ad layout #555

merged 1 commit into from Nov 1, 2020

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Oct 28, 2020

Description of the Changes

Create a wrapper component for the ad left controls and move the logic to there.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv requested a review from OrenMe October 28, 2020 17:59
@dan-ziv dan-ziv self-assigned this Oct 28, 2020
@dan-ziv dan-ziv closed this Oct 29, 2020
@dan-ziv dan-ziv reopened this Oct 29, 2020
@dan-ziv dan-ziv closed this Oct 29, 2020
@dan-ziv dan-ziv reopened this Oct 29, 2020
@OrenMe OrenMe merged commit 0a68502 into master Nov 1, 2020
@OrenMe OrenMe deleted the FEC-10481-v3 branch November 1, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @OrenMe