Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7144): round up the timer values of an ad #56

Merged
merged 3 commits into from
Sep 18, 2017
Merged

fix(FEC-7144): round up the timer values of an ad #56

merged 3 commits into from
Sep 18, 2017

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Sep 18, 2017 •
edited

Description of the Changes

Ads "left timer counts" doesn't present the last second, round up the current time and duration.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Sep 18, 2017
@dan-ziv dan-ziv changed the title fix(FEC-7144): fix left timer counts fix(FEC-7144): round up the timer values of an ad Sep 18, 2017
@dan-ziv dan-ziv merged commit 6faf57b into master Sep 18, 2017
@dan-ziv dan-ziv deleted the fix-left-timer-counts branch September 18, 2017 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

@OrenMe OrenMe Awaiting requested review from OrenMe

@dvh91 dvh91 Awaiting requested review from dvh91

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @yairans