Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10779): add the all JSLogger for stubbing #564

Merged
merged 2 commits into from
Dec 27, 2020
Merged

fix(FEC-10779): add the all JSLogger for stubbing #564

merged 2 commits into from
Dec 27, 2020

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Dec 8, 2020

Description of the Changes

issue: missing methods and properties for getLogger.
solution: add the stubbing for all the methods and properties.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke
fix(FEC-10779): add the all JSLogger for stubbing
44855ba 
issue: missing methods and properties for getLogger
solution: add the stubbing for all the methods and properties
@Yuvalke Yuvalke requested a review from a team December 8, 2020 11:21
@Yuvalke Yuvalke self-assigned this Dec 8, 2020
@Yuvalke Yuvalke merged commit afa194d into master Dec 27, 2020
@Yuvalke Yuvalke deleted the FEC-10779 branch December 27, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@Yuvalke Yuvalke

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Yuvalke @OrenMe