fix(FEC-10784): No spinner between the preroll and the playback when disableMediaPreload is true #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…disableMediaPreload is true Issue: No spinner between the preroll and the playback when disableMediaPreload is true. Solution: remove the afterPlayingEvent flag to show the spinner before playing event as expected.
RoyBregman
reviewed
Dec 20, 2020
There was a problem hiding this comment.
This "afterPlayerEvent" state was added due to this ticket:
https://kaltura.atlassian.net/browse/FEC-7368
Please make sure the scenario described in the original ticket is not reproduced
Of course, already take into account |
OrenMe
approved these changes
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue: No spinner between the preroll and the playback when disableMediaPreload is true.
Solution: remove the afterPlayingEvent flag to show the spinner before playing the event as expected, no regression from https://kaltura.atlassian.net/browse/FEC-7368 ad_break_start shows the loading state and autoplay_failed remove the loading state.
CheckLists