Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-7101): remove auto bitrate option for progressive playback #57

Merged
merged 3 commits into from
Sep 25, 2017

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Sep 24, 2017

Description of the Changes

only add auto option for non progressive playback.
depends on exposing streamType on playkit-js here: kaltura/playkit-js#120.
currently we rely on strings but this should be added as types and constants from player.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

depends on exposing streamType on playkit-js
@dan-ziv dan-ziv merged commit d2c1612 into master Sep 25, 2017
@dan-ziv dan-ziv deleted the FEC-7101 branch September 25, 2017 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants