Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow side panel and player area on the idle preset #574

Merged
merged 2 commits into from
Jan 13, 2021
Merged

feat: allow side panel and player area on the idle preset #574

merged 2 commits into from
Jan 13, 2021

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jan 12, 2021 •
edited

Description of the Changes

make side panels persistent between medias

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested review from OrenMe and a team January 12, 2021 21:47
@yairans yairans self-assigned this Jan 12, 2021
@yairans yairans merged commit c5ea46a into master Jan 13, 2021
@yairans yairans deleted the idle-side-panel branch January 13, 2021 11:41
@JonathanTGold JonathanTGold mentioned this pull request Aug 11, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@yairans yairans

Labels
Priority: High
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @OrenMe