Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10957): CastBeforePlay button is not aligned to the center #577

Merged
merged 1 commit into from
Jan 31, 2021
Merged

fix(FEC-10957): CastBeforePlay button is not aligned to the center #577

merged 1 commit into from
Jan 31, 2021

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Jan 31, 2021 •
edited

Description of the Changes

When page defines margin:auto for divs, cast before play button is not aligned to the center.
css fixes:

  1. Remve redundant div.
  2. Container div should cover player.
  3. Child div should center the button correctly.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Jan 31, 2021
@dan-ziv dan-ziv merged commit e52f990 into master Jan 31, 2021
@dan-ziv dan-ziv deleted the FEC-10957 branch January 31, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

@Yuvalke Yuvalke Awaiting requested review from Yuvalke

@RoyBregman RoyBregman Awaiting requested review from RoyBregman

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @OrenMe