Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7182): update UI accorindg to mute status change #58

Merged
merged 2 commits into from
Sep 25, 2017
Merged

fix(FEC-7182): update UI accorindg to mute status change #58

merged 2 commits into from
Sep 25, 2017

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Sep 24, 2017 •
edited

Description of the Changes

listen to player mute status change and update UI.
depends on kaltura/playkit-js#121

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe
fix(FEC-7182): update UI accorindg to mute status change
70ac3a8 
listen to player mute status change and update UI
@OrenMe OrenMe self-assigned this Sep 24, 2017
@dan-ziv dan-ziv merged commit a09ff7b into master Sep 25, 2017
@dan-ziv dan-ziv deleted the FEC-7182 branch September 25, 2017 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

@dvh91 dvh91 Awaiting requested review from dvh91

@yairans yairans Awaiting requested review from yairans

@odedhutzler odedhutzler Awaiting requested review from odedhutzler

Assignees

@OrenMe OrenMe

Labels
Priority: Medium Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OrenMe @dan-ziv