Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-10281): chromecast does not work after playing it once and trying it on another video #582

Merged
merged 3 commits into from
Mar 14, 2021

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Feb 22, 2021

Description of the Changes

Check for cast availability from previous sessions when source is selected.

Solves FEC-10281
Related to kaltura/playkit-js-cast-sender#51

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Feb 22, 2021
@@ -41,6 +41,7 @@ class EngineConnector extends Component {
});

eventManager.listen(player, player.Event.SOURCE_SELECTED, () => {
this.props.updateIsCastAvailable(player.isCastAvailable());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it working for 2 players as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even for 10 :)

@dan-ziv dan-ziv merged commit a377d60 into master Mar 14, 2021
@dan-ziv dan-ziv deleted the FEC-10281 branch March 14, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants