Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-10947): change all events callbacks from anonymous to bound functions #585

Merged
merged 5 commits into from
Mar 21, 2021
Merged

feat(FEC-10947): change all events callbacks from anonymous to bound functions #585

merged 5 commits into from
Mar 21, 2021

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Mar 16, 2021

Description of the Changes

Change all events callbacks from anonymous to bound functions.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Mar 16, 2021
yairans
yairans previously approved these changes Mar 18, 2021
View reviewed changes
@dan-ziv dan-ziv merged commit 4f26455 into master Mar 21, 2021
@dan-ziv dan-ziv deleted the FEC-10947 branch March 21, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans left review comments

@OrenMe OrenMe Awaiting requested review from OrenMe

@Yuvalke Yuvalke Awaiting requested review from Yuvalke

@RoyBregman RoyBregman Awaiting requested review from RoyBregman

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @yairans