Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-11100): bumper advertisement text appears for second when bumper starts #586

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Mar 22, 2021

Description of the Changes

Issue:

  1. UI bumper change status on ad_started which could be too late and show the text "advertisement" for a second.
  2. ad_started used because bumper dispatch ad_loaded once before pre-roll for pre-roll and post-roll so with IMA mid-roll it'll keep the advertisement text.

Solution:

  1. add ad_loaded handler to avoid this use case that the status change is too late, ad_loaded will change the status.
  2. ad_started shouldn't change the status only on case 2 mentioned above.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

…mper starts

Issue: UI bumper change status on ad_started which could be too late and show the text "advertisement" for a second. ad_started used because bumper dispatch ad_loaded once for pre and post roll before pre-roll so with IMA it'll keep the advertisement text.
Solution: keep the ad_started to solve the second issue mentioned here.
also add ad_loaded to avoid this use case which the change is too late, ad_loaded will change the status and ad_started shouldn't change only on the first case mentioned above.
@Yuvalke Yuvalke requested a review from a team March 22, 2021 16:10
@Yuvalke Yuvalke self-assigned this Mar 22, 2021
@Yuvalke Yuvalke merged commit a7a8ccd into master Mar 24, 2021
@Yuvalke Yuvalke deleted the FEC-11100 branch March 24, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants