Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-11128): X button on floating player not working #590

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

lianbenjamin
Copy link
Collaborator

@lianbenjamin lianbenjamin commented Apr 6, 2021

Description of the Changes

when an ad is playing, the dismiss button is showing but not working.
made all left-controls and right-controls children clickthrough and excepted ad-notice.

Solves FEC-11128

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

RoyBregman
RoyBregman previously approved these changes Apr 6, 2021
@@ -28,6 +30,10 @@
&:empty {
margin: 0;
}

.ad-notice {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ad notice has its own css file. do it there

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yairans it's not working when adding this to ad-notice.scss. the adding of pointer-events:auto to top-bar's children is stronger. we needed to add another level to make this one stronger.


.left-controls *,
.right-controls * {
pointer-events: auto;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the top-bar itself it also a container so add this in it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with scss you can do like:

  &.disabled {
    pointer-events: none;
    * {
       pointer-events: auto;
    }
  }```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tried first what you suggested but it doesn't fix the issue correctly. The problem is that the left and right controller also have dimensions due to its children, so it is also grabbing the clicks. That is why we lowered it another level

@lianbenjamin lianbenjamin merged commit 6e3916b into master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants