fix(FEC-11151): quality dropdown is cropped when user clicks on ‘Quality’ settings on the player after scrolling down #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity’ settings on the player after scrolling down
dan-ziv
suggested changes
Apr 18, 2021
src/components/shell/shell.js
Outdated
| eventManager.listen( | ||
| document, | ||
| 'scroll', | ||
| debounce(() => { |
There was a problem hiding this comment.
remove the anonymous function and use arrow function for the callback _onDocumentScroll
src/components/shell/shell.js
Outdated
| @@ -233,7 +240,7 @@ class Shell extends Component { | |||
| FakeEvent.Type.RESIZE, | |||
| debounce(() => { | |||
dan-ziv
reviewed
Apr 18, 2021
src/components/shell/shell.js
Outdated
| * @returns {void} | ||
| * @memberof Shell | ||
| */ | ||
| _onDocumentScroll(): void { |
There was a problem hiding this comment.
If we don't have any more logic in it, no need this function, define just _updatePlayerClientRect as a callback for the document scroll event.
dan-ziv
approved these changes
Apr 18, 2021
|
@yairans don't we need to change in |
|
No. Gui updated from player |
dan-ziv
approved these changes
Apr 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
update the player client rect on document.scroll event
CheckLists