Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-11219): share tooltip not localized #595

Merged
merged 5 commits into from
May 9, 2021
Merged

fix(FEC-11219): share tooltip not localized #595

merged 5 commits into from
May 9, 2021

Conversation

yairans
Copy link
Contributor

@yairans yairans commented May 6, 2021 •
edited

Description of the Changes

use Localizer for the share buttons

Solves FEC-11219

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team May 6, 2021 22:06
@yairans yairans self-assigned this May 6, 2021
@yairans yairans merged commit e436218 into master May 9, 2021
@yairans yairans deleted the FEC-11219 branch May 9, 2021 07:12
yairans added a commit that referenced this pull request May 9, 2021
@yairans
fix(FEC-11219): share tooltip not localized (#595)
219e984 
Use Localizer for the share buttons

Solves FEC-11219

(cherry picked from commit e436218)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuvalke Yuvalke Yuvalke approved these changes

@semarche-kaltura semarche-kaltura semarche-kaltura approved these changes

Assignees

@yairans yairans

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yairans @Yuvalke @semarche-kaltura