fix(FEC-10811): floating show two bottom bar for second #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: first event of resize/scroll doesn't take into account. Solution: trigger the function on the leading edge instead of trail.
RoyBregman
previously approved these changes
May 9, 2021
OrenMe
requested changes
May 9, 2021
src/utils/debounce.js
Outdated
| let timeout; | ||
|
|
||
| return (...args) => { | ||
| const context = this; | ||
| if (immediate && !timeout) origFunc.apply(context, args); |
There was a problem hiding this comment.
Do not use inline ifs without curly brackets.
@yairans letw make sure we have lint rule to make sure this is not possible
|
@Yuvalke sid you mean to write "isn't taken into account"? |
yairans
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue: the first event of resize/scroll isn't taken into account only the last one in the sequence.
Solution: trigger the function on the leading edge instead of the trail.
CheckLists