feat: use off caption from playkit #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-ziv
reviewed
Oct 2, 2017
src/components/language/language.js
Outdated
| * | ||
| * @param {(Object | string)} textTrack - text track or 'off' string | ||
| * @param {(Object | string)} textTrack - text track | ||
| * @returns {void} | ||
| * @memberof LanguageControl | ||
| */ | ||
| onCaptionsChange(textTrack: Object | string): void { |
There was a problem hiding this comment.
Now the param type is only Object
dan-ziv
approved these changes
Oct 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
PlayKit creates a pseudo off text track when there are text tracks available.
This is for connivance only and it internally just tells PlayKit to call hideTextTrack, but it supports the model of emitting the text track change with the selected track where in case of off option it will properly add it to the event payload instead of just throwing null.
Depends on kaltura/playkit-js#118
CheckLists