Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: encode share url #600

Merged
merged 2 commits into from
May 9, 2021
Merged

fix: encode share url #600

merged 2 commits into from
May 9, 2021

Conversation

yairans
Copy link
Contributor

@yairans yairans commented May 9, 2021 •
edited

Description of the Changes

use encodeURIComponent on the share url

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from OrenMe May 9, 2021 17:02
@yairans yairans self-assigned this May 9, 2021
@yairans yairans merged commit c8a4bfe into 0.65.6 May 9, 2021
@yairans yairans deleted the encode-share branch May 9, 2021 17:46
yairans added a commit that referenced this pull request May 9, 2021
@yairans
fix: encode share url (#600)
3532881 
use encodeURIComponent on the share url

(cherry picked from commit c8a4bfe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe Awaiting requested review from OrenMe

Assignees

@yairans yairans

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@yairans