Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-10835): expose share to plugin #603

Merged
merged 13 commits into from
Jun 27, 2021
Merged

feat(FEC-10835): expose share to plugin #603

merged 13 commits into from
Jun 27, 2021

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented May 20, 2021

Description of the Changes

Expose share component to plugin, related issues:
Issues:

  1. have multiple overlay states for CVAA and Share.
  2. related components weren't exported.
  3. CVAA doesn't behave correctly with the keyboard since the state wasn't taken into account keyboard components.

Solution:

  1. add a new prop to overlay to handle it inside it.
  2. export all relevant components.
  3. Overlay will be handle once and have a common state so it'll be fixed.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

yairans
yairans previously approved these changes Jun 20, 2021
src/styles/_buttons.scss Outdated Show resolved Hide resolved
@@ -201,6 +203,12 @@ export default (state: Object = initialState, action: Object) => {
smartContainerOpen: action.open
};

case types.UPDATE_OVERLAY:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move it to overlay reducer as this is overlay action?

Copy link
Contributor Author

@Yuvalke Yuvalke Jun 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can but it changes the shell prop, it seems like it better to handle all shell in single reducer

@Yuvalke Yuvalke merged commit 74b187f into master Jun 27, 2021
@Yuvalke Yuvalke deleted the FEC-10835 branch June 27, 2021 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants