-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FEC-10835): expose share to plugin #603
Conversation
src/reducers/shell.js
Outdated
@@ -201,6 +203,12 @@ export default (state: Object = initialState, action: Object) => { | |||
smartContainerOpen: action.open | |||
}; | |||
|
|||
case types.UPDATE_OVERLAY: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we move it to overlay reducer as this is overlay action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can but it changes the shell prop, it seems like it better to handle all shell in single reducer
Description of the Changes
Expose share component to plugin, related issues:
Issues:
Solution:
CheckLists