Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-10613): add Hebrew/Canadian French translations for player #604

Merged
merged 2 commits into from
May 25, 2021
Merged

feat(FEC-10613): add Hebrew/Canadian French translations for player #604

merged 2 commits into from
May 25, 2021

Conversation

yairans
Copy link
Contributor

@yairans yairans commented May 20, 2021 •
edited

Description of the Changes

  • add Hebrew and Canadian French translations
  • add translations for "pictureInPictureExit" and "qualityAuto" in all langs

Solves FEC-10613

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team May 20, 2021 15:51
@yairans yairans self-assigned this May 20, 2021
OrenMe
OrenMe previously approved these changes May 20, 2021
View reviewed changes
@yairans yairans merged commit 3b251e6 into master May 25, 2021
@yairans yairans deleted the FEC-10613 branch May 25, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe left review comments

Assignees

@yairans yairans

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @OrenMe