feat(FEC-11284): dual screen core changes #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyBregman
requested review from
yairans,
Yuvalke,
dan-ziv,
OrenMe and
a team
and removed request for
yairans and
Yuvalke
dan-ziv
reviewed
May 26, 2021
src/components/icon/icon.js
Outdated
| * @returns {string} - encoded svg url | ||
| * @memberof Icon | ||
| */ | ||
| getSVGUrl = (path: string): string => { | ||
| const svg = `<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 1024 1024" width="36" height="36">${path}</svg>`; | ||
| getSVGUrl = (path: string, width: ?number = 36, height: ?number = 36): string => { |
There was a problem hiding this comment.
should be
width?: number = 36, height?: number = 36
There was a problem hiding this comment.
should be w/o "?" actually . Fixed
|
@RoyBregman please only use FEC in ticket titles. @yairans FYI. Cross dependencies should be defined in FEC ticket and tested in core separately for regressions. |
RoyBregman
changed the title
Done - updated PR title |
yairans
suggested changes
May 27, 2021
|
If we change the UI vars in a way that requires updating the CSS guide than please update it |
yairans
suggested changes
Jun 1, 2021
yairans
approved these changes
Jun 1, 2021
RoyBregman
added a commit
that referenced
this pull request
Jun 2, 2021
This reverts commit e3df209.
RoyBregman
added a commit
that referenced
this pull request
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
As part of the dual screen plugin development there are several changes that needed to be done in the ui:
CheckLists