feat: change media #61
Conversation
| this.props.updatePrePlayback(false); | ||
| this.props.removePlayerClass('pre-playback'); | ||
| }); | ||
| this.player.addEventListener(this.player.Event.PLAY, this._hidePrePlayback.bind(this)); |
There was a problem hiding this comment.
use ()=>this. _hidePrePlayback()
| @@ -146,6 +139,30 @@ class PrePlaybackPlayOverlay extends BaseComponent { | |||
| </div> | |||
| ) | |||
| } | |||
|
|
|||
| _addBindings(): void { | |||
| this.player.addEventListener(this.player.Event.CHANGE_SOURCE_ENDED, this._onChangeSourceEnded.bind(this)); | |||
There was a problem hiding this comment.
missing JSDoc.
Beeter discuss with @dvh91 before adding _addBindings convention, as Preact might have something else
There was a problem hiding this comment.
You can use componentWillMount function from the component lifecycle and get rid of the addBindings function.
| this.player.addEventListener(this.player.Event.CHANGE_SOURCE_ENDED, this._onChangeSourceEnded.bind(this)); | ||
| } | ||
|
|
||
| _onChangeSourceEnded(): void { |
| @@ -33,6 +33,10 @@ class EngineConnector extends BaseComponent { | |||
| componentDidMount() { | |||
| const TrackType = this.player.Track; | |||
|
|
|||
| this.player.addEventListener(this.player.Event.CHANGE_SOURCE_ENDED, () => { | |||
| this.props.updatePlayerPoster(this.player.poster); | |||
There was a problem hiding this comment.
why is this needed? for scrubber preview? @dvh91 if this is the case, as with other places where you fetch the poster for this, then we should extract this and have the UI config get the dedicated scrubber config(e.g. the "backed" url and number of segments and width)
There was a problem hiding this comment.
If we are not auto playing the next media we want to see the updated poster
…o change-media
…o change-media
… into change-media
…o change-media
… into change-media
Description of the Changes
UI handling of change media.
Needs to be merge after playkit-js PR will be merged.
CheckLists