Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-11364): Live Dvr - if seek back, the scrubber "jumps" too far back and after return to correct point #615

Merged
merged 5 commits into from
Jun 29, 2021
Merged

fix(FEC-11364): Live Dvr - if seek back, the scrubber "jumps" too far back and after return to correct point #615

merged 5 commits into from
Jun 29, 2021

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Jun 29, 2021 •
edited by yairans

Description of the Changes

Instead of adding the dvr window after the seek, add it as part of the seek.

Solves FEC-11364

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv requested a review from yairans June 29, 2021 10:17
@dan-ziv dan-ziv self-assigned this Jun 29, 2021
yairans
yairans suggested changes Jun 29, 2021
View reviewed changes
src/components/seekbar/seekbar.js Outdated Show resolved Hide resolved
yairans
yairans previously approved these changes Jun 29, 2021
View reviewed changes
@dan-ziv dan-ziv requested a review from yairans June 29, 2021 12:50
@yairans yairans merged commit 6bc4651 into master Jun 29, 2021
@yairans yairans deleted the FEC-11364 branch June 29, 2021 13:01
yairans added a commit that referenced this pull request Jul 13, 2021
@yairans
Revert "fix(FEC-11364): Live Dvr - if seek back, the scrubber "jumps"…
36adf80 
… too far back and after return to correct point (#615)"

This reverts commit 6bc4651
yairans added a commit that referenced this pull request Jul 13, 2021
@yairans
Revert "Revert "fix(FEC-11364): Live Dvr - if seek back, the scrubber…
dfe9bb4 
… "jumps" too far back and after return to correct point (#615)""

This reverts commit 36adf80
@yairans yairans mentioned this pull request Jul 14, 2021
Merged
5 tasks
yairans added a commit that referenced this pull request Jul 14, 2021
@yairans
fix(FEC-11400): live seekbar doesn't work properly - regression (#622)
12dcac3 
revert #589 and #615 
make the live seekbar range between dvr start to the live duration

Solves FEC-11400
yairans added a commit that referenced this pull request Jul 15, 2021
@yairans
fix(FEC-11400): live seekbar doesn't work properly - regression (#622)
0d62026 
revert #589 and #615
make the live seekbar range between dvr start to the live duration

Solves FEC-11400

(cherry picked from commit 12dcac3)
borhandarabi pushed a commit to TasvirChi/playchi-js-ui that referenced this pull request May 15, 2024
fix(FEC-11400): live seekbar doesn't work properly - regression (#622)
b129ee9 
revert kaltura/playkit-js-ui#589 and kaltura/playkit-js-ui#615 
make the live seekbar range between dvr start to the live duration

Solves FEC-11400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @yairans