Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-11401): End key jumps over the live edge - regression #623

Merged
merged 10 commits into from
Jul 14, 2021
Merged

fix(FEC-11401): End key jumps over the live edge - regression #623

merged 10 commits into from
Jul 14, 2021

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jul 13, 2021 •
edited

Description of the Changes

use liveDuration and getStartTimeOfDvrWindow in live playback

Solves FEC-11401

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans
Revert "fix(FEC-11364): Live Dvr - if seek back, the scrubber "jumps"…
36adf80 
… too far back and after return to correct point (#615)"

This reverts commit 6bc4651
@yairans
Revert "feat(FEC-10817): expose the current time of the video element…
b71bd07 
… in live streams (#589)"

This reverts commit d257ef9
@yairans
fix(FEC-11400): live seekbar doesn't work properly - regression
0943af9
@yairans
End key jumps over the live edge - regression
3c131b7
@yairans
Revert "fix(FEC-11400): live seekbar doesn't work properly - regression"
571381c 
This reverts commit 0943af9
@yairans
Revert "Revert "feat(FEC-10817): expose the current time of the video…
5a08cd1 
… element in live streams (#589)""

This reverts commit b71bd07
@yairans
Revert "Revert "fix(FEC-11364): Live Dvr - if seek back, the scrubber…
dfe9bb4 
… "jumps" too far back and after return to correct point (#615)""

This reverts commit 36adf80
@yairans
remove unrelated change
d5e8997
OrenMe
OrenMe previously approved these changes Jul 14, 2021
View reviewed changes
RoyBregman
RoyBregman previously approved these changes Jul 14, 2021
View reviewed changes
@yairans yairans dismissed stale reviews from RoyBregman and OrenMe via 652a0de July 14, 2021 10:07
@yairans yairans merged commit b446895 into master Jul 14, 2021
@yairans yairans deleted the FEC-11401 branch July 14, 2021 10:36
yairans added a commit that referenced this pull request Jul 15, 2021
@yairans
fix(FEC-11401): End key jumps over the live edge - regression (#623)
cf418fc 
use `liveDuration` and `getStartTimeOfDvrWindow` in live playback

Solves FEC-11401

(cherry picked from commit b446895)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe left review comments

@RoyBregman RoyBregman RoyBregman left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yairans @OrenMe @RoyBregman