Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-11413): live time is 0 in wrong place #624

Merged
merged 4 commits into from
Jul 15, 2021
Merged

fix(FEC-11413): live time is 0 in wrong place #624

merged 4 commits into from
Jul 15, 2021

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jul 14, 2021 •
edited

Description of the Changes

Issue: SeekBarLivePlaybackContainer mounted after the initial DURATION_CHANGE event so it will be updated only once the next segment will be loaded so meanwhile, the duration is 0
Solution: use the engine duration and manipulate it internally

Solves FEC-11413

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from RoyBregman July 14, 2021 21:03
@yairans yairans changed the title fix(FEC-11413): live time is 0 and in wrong place fix(FEC-11413): live time is 0 in wrong place Jul 14, 2021
RoyBregman
RoyBregman previously approved these changes Jul 15, 2021
View reviewed changes
@yairans yairans merged commit 23cecec into master Jul 15, 2021
@yairans yairans deleted the FEC-11413 branch July 15, 2021 06:57
yairans added a commit that referenced this pull request Jul 15, 2021
@yairans
fix(FEC-11413): live time is 0 in wrong place (#624)
9f0be8b 
Issue: SeekBarLivePlaybackContainer mounted after the initial `DURATION_CHANGE` event so it will be updated only once the next segment will be loaded so meanwhile, the duration is 0
Solution: use the engine duration and manipulate it internally

Solves FEC-11413

(cherry picked from commit 23cecec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoyBregman RoyBregman RoyBregman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @RoyBregman