Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-10287): on 'Picture in picture' mode, the tooltip shall be "expand” instead of "Exit pictures in pictures" #625

Merged
merged 2 commits into from
Jul 19, 2021
Merged

feat(FEC-10287): on 'Picture in picture' mode, the tooltip shall be "expand” instead of "Exit pictures in pictures" #625

merged 2 commits into from
Jul 19, 2021

Conversation

JonathanTGold
Copy link
Collaborator

Description of the Changes

on 'Picture in picture' mode, the tooltip shall be "expand” instead of "Exit pictures in pictures

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@JonathanTGold
feat(FEC-10287): on 'Picture in picture' mode, the tooltip shall be “…
1cd27da 
…expand” instead of "Exit pictures in pictures"
@JonathanTGold JonathanTGold merged commit 1c9c1d6 into master Jul 19, 2021
@yairans yairans deleted the FEC-10287 branch July 19, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

@RoyBregman RoyBregman Awaiting requested review from RoyBregman

Assignees
No one assigned
Labels
Type: Feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JonathanTGold @yairans