Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-11419): explore why Live Start over starts with few seconds delay #626

Merged
merged 1 commit into from
Jul 21, 2021
Merged

fix(FEC-11419): explore why Live Start over starts with few seconds delay #626

merged 1 commit into from
Jul 21, 2021

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jul 20, 2021 •
edited

Description of the Changes

  1. prevent currentTime to be negative
  2. add missing event disaptcher case of live seekbar
  3. don't use the currentTime and duration from the player but from props

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Jul 20, 2021
@yairans yairans merged commit 2892bac into master Jul 21, 2021
@yairans yairans deleted the FEC-11419 branch July 21, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@RoyBregman RoyBregman Awaiting requested review from RoyBregman

@JonathanTGold JonathanTGold Awaiting requested review from JonathanTGold

Assignees

@yairans yairans

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @OrenMe