feat(FEC-10666): add HD/4K indication in quality selector #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanTGold
changed the title
RoyBregman
reviewed
Jul 27, 2021
JonathanTGold
requested review from
RoyBregman
and removed request for
RoyBregman
yairans
suggested changes
Aug 4, 2021
JonathanTGold
requested review from
yairans and
RoyBregman
and removed request for
RoyBregman
yairans
reviewed
Aug 8, 2021
yairans
reviewed
Aug 8, 2021
yairans
reviewed
Aug 8, 2021
yairans
previously approved these changes
Aug 9, 2021
yairans
previously approved these changes
Aug 9, 2021
…plied only on label contains badge icon
yairans
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
We wish to add a simple indication that would allow millennials to know the quality they are watching.
Requirements
For resolutions, where height is between 720 (included) and 2160 (excluded) add an HD indication.
For resolutions, where height is between 2160 (included) and 4320 (excluded) add a 4K indication.
For resolutions, where height is above 4320 (included) add a 8K indication.
solves FEC-10666
CheckLists