Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-11517): CVAA - dropdown lists for captions style don't open - regression #636

Merged
merged 1 commit into from
Aug 30, 2021
Merged

fix(FEC-11517): CVAA - dropdown lists for captions style don't open - regression #636

merged 1 commit into from
Aug 30, 2021

Conversation

JonathanTGold
Copy link
Collaborator

Description of the Changes

restore the remove css properties in dropdown.scss and fallback label in dropdown.js

fix: FEC-11517

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@JonathanTGold JonathanTGold changed the title fix(FEC-11517): dropdown lists for captions style open at the bottom left - regression fix(FEC-11517): V3 - CVAA - dropdown lists for captions style don't open - regression Aug 30, 2021
@JonathanTGold JonathanTGold changed the title fix(FEC-11517): V3 - CVAA - dropdown lists for captions style don't open - regression fix(FEC-11517): CVAA - dropdown lists for captions style don't open - regression Aug 30, 2021
@JonathanTGold JonathanTGold merged commit 9ef65b9 into master Aug 30, 2021
@JonathanTGold JonathanTGold deleted the FEC-11517 branch August 30, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

@SivanA-Kaltura SivanA-Kaltura Awaiting requested review from SivanA-Kaltura

@RoyBregman RoyBregman Awaiting requested review from RoyBregman

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JonathanTGold @yairans