Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-11708): V3 - cast on multiple players - if try to cast when other player are casting, the player will be disabled #643

Merged
merged 3 commits into from
Nov 23, 2021

Conversation

SivanA-Kaltura
Copy link
Collaborator

@SivanA-Kaltura SivanA-Kaltura commented Nov 22, 2021

Description of the Changes

Cast backdrop has issues with multiple players.
Since backdrop is no longer necessary it can be removed.
Also clear isCastInitiator if cast request failed.
Fixes FEC-11708.
Related PR: kaltura/playkit-js-cast-sender#72

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@SivanA-Kaltura SivanA-Kaltura requested a review from a team November 22, 2021 12:22
Copy link
Contributor

@yairans yairans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete the component and reducer as well and also the uses in presets

@SivanA-Kaltura SivanA-Kaltura merged commit cc1e421 into master Nov 23, 2021
@SivanA-Kaltura SivanA-Kaltura deleted the FEC-11708-remove-cast-backdrop branch November 23, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants