Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-11733): Hide mouse cursor when it's idle in fullscreen #647

Merged
merged 1 commit into from
Jan 13, 2022
Merged

fix(FEC-11733): Hide mouse cursor when it's idle in fullscreen #647

merged 1 commit into from
Jan 13, 2022

Conversation

JonathanTGold
Copy link
Collaborator

@JonathanTGold JonathanTGold commented Jan 12, 2022 •
edited

Description of the Changes

use the same technique like we use to hide the bottom bar and use the css classes representing the player state to toggle the cursor (hide and show it along with the bottom bar)

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@JonathanTGold JonathanTGold self-assigned this Jan 12, 2022
yairans
yairans suggested changes Jan 12, 2022
View reviewed changes
src/styles/_shell.scss Show resolved Hide resolved
@JonathanTGold JonathanTGold merged commit 171bfd5 into master Jan 13, 2022
@JonathanTGold JonathanTGold deleted the FEC-11733 branch January 13, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

@SivanA-Kaltura SivanA-Kaltura Awaiting requested review from SivanA-Kaltura

Assignees

@JonathanTGold JonathanTGold

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JonathanTGold @yairans