-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FEC-12113): Add Side Panels Management to player UI #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
5 tasks
yairans
reviewed
May 4, 2022
yairans
suggested changes
May 4, 2022
yairans
suggested changes
May 11, 2022
Co-authored-by: Yair Ansbacher <yairans@gmail.com>
Co-authored-by: Yair Ansbacher <yairans@gmail.com>
JonathanTGold
added a commit
to kaltura/kaltura-player-js
that referenced
this pull request
May 12, 2022
Add TypeScript types support according to last new typescript spec Related pr: kaltura/playkit-js-ui-managers#1 kaltura/playkit-js-ui#674
yairans
approved these changes
May 12, 2022
JonathanTGold
added a commit
to kaltura/playkit-js-ui-managers
that referenced
this pull request
May 16, 2022
Add Side Panels Management to player UI Related pr: kaltura/playkit-js-ui#674 kaltura/kaltura-player-js#544 #2 solves: FEC-12113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Expose public enums needed across plugins
Related pr:
kaltura/playkit-js-ui-managers#1
kaltura/kaltura-player-js#544
solves: FEC-12113
CheckLists