Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-12113): Add Side Panels Management to player UI #674

Merged
merged 10 commits into from
May 16, 2022

Conversation

JonathanTGold
Copy link
Collaborator

@JonathanTGold JonathanTGold commented May 2, 2022

Description of the Changes

Expose public enums needed across plugins

Related pr:
kaltura/playkit-js-ui-managers#1
kaltura/kaltura-player-js#544

solves: FEC-12113

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

src/reducers/shell.js Outdated Show resolved Hide resolved
src/reducers/shell.js Show resolved Hide resolved
@JonathanTGold JonathanTGold requested a review from yairans May 9, 2022 09:12
JonathanTGold added 2 commits May 9, 2022 17:49
src/reducers/shell.js Outdated Show resolved Hide resolved
src/ui-presets/ads.js Outdated Show resolved Hide resolved
JonathanTGold and others added 3 commits May 11, 2022 15:12
Co-authored-by: Yair Ansbacher <yairans@gmail.com>
Co-authored-by: Yair Ansbacher <yairans@gmail.com>
JonathanTGold added a commit to kaltura/kaltura-player-js that referenced this pull request May 12, 2022
Add TypeScript types support according to last new typescript spec

Related pr:
kaltura/playkit-js-ui-managers#1
kaltura/playkit-js-ui#674
JonathanTGold added a commit to kaltura/playkit-js-ui-managers that referenced this pull request May 16, 2022
@JonathanTGold JonathanTGold merged commit 60ee1d1 into master May 16, 2022
@JonathanTGold JonathanTGold deleted the FEC-12113 branch May 16, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants