Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-12245): add i18n to CC button: wrong tooltip for German (the same with Dutch) #675

Merged
merged 2 commits into from
May 17, 2022
Merged

fix(FEC-12245): add i18n to CC button: wrong tooltip for German (the same with Dutch) #675

merged 2 commits into from
May 17, 2022

Conversation

yairans
Copy link
Contributor

@yairans yairans commented May 12, 2022 •
edited

Description of the Changes

fix de (German) json

Solves FEC-12245

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team May 12, 2022 13:03
@yairans yairans changed the title fix(FEC-12245): add i18n to CC button: wrong tooltip for Dutch (the same with German) fix(FEC-12245): add i18n to CC button: wrong tooltip for German (the same with Dutch) May 17, 2022
@yairans yairans merged commit 596c875 into master May 17, 2022
@yairans yairans deleted the FEC-12245 branch May 17, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SivanA-Kaltura SivanA-Kaltura SivanA-Kaltura approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @SivanA-Kaltura