Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-12097): More plugins - Manage the UI & order of the plugin icons #688

Merged
merged 13 commits into from
Sep 25, 2022

Conversation

JonathanTGold
Copy link
Collaborator

@JonathanTGold JonathanTGold commented Aug 28, 2022

Description of the Changes

solves: FEC-12097 & FEC-12500, FEC-12497, FEC-12538, FEC-12553

related pr:
kaltura/playkit-js-ui-managers#10

in addition to the required changes from upper bar manager pr
the following general UI bugs were fixed: FEC-12500, FEC-12497, FEC-12538, FEC-12553

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

src/components/top-bar/_top-bar.scss Outdated Show resolved Hide resolved
src/ui-presets/playback.js Show resolved Hide resolved
@esakal esakal removed their request for review September 7, 2022 08:00
src/styles/_plugin-button.scss Outdated Show resolved Hide resolved
@JonathanTGold JonathanTGold merged commit 01d2efa into master Sep 25, 2022
JonathanTGold added a commit to kaltura/playkit-js-ui-managers that referenced this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants