Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-12517): [web v7] volume bar arrow keys accessibility #689

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

lianbenjamin
Copy link
Collaborator

@lianbenjamin lianbenjamin commented Aug 30, 2022

the issue:
when navigating to volume component using the keyboard and pressing up/down arrows (to volume up/down), the entire page is scrolling.
another related issue that was observed- when the volume bar is open via a11y (using keyboard), then clicking anywhere is not closing the volume bar; it should be close in this case.

root cause:
we do not prevent from the keyboard event to bubble. when pressing up/down keyboard arrows, the native event scrolls the page.

Description of the Changes

  • preventing from keyboard event to bubble
  • closing the volume bar once clicking outside the component

Solves FEC-12517

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@JonathanTGold JonathanTGold merged commit 763c297 into master Sep 12, 2022
@giladna giladna deleted the FEC-12517-volume-bar-a11y branch September 28, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants