Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-12598): Regression - in the quality dropdown there are 3 dots instead the complete word #696

Merged
merged 1 commit into from
Sep 28, 2022
Merged

fix(FEC-12598): Regression - in the quality dropdown there are 3 dots instead the complete word #696

merged 1 commit into from
Sep 28, 2022

Conversation

Tzipi-kaltura
Copy link
Contributor

@Tzipi-kaltura Tzipi-kaltura commented Sep 28, 2022 •
edited by JonathanTGold

Description of the Changes

the issue:
after change the player font to Lato, in quality dropdown is created 3 dotes when translate for Hebrew.

the solution:
remove the max-width from the dropdown style.

solves: FEC-12598

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Tzipi-kaltura Tzipi-kaltura merged commit e10264f into master Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanTGold JonathanTGold JonathanTGold approved these changes

@giladna giladna Awaiting requested review from giladna

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tzipi-kaltura @JonathanTGold