Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-12728): Buttons for caption customization do not have descriptive names (they all say, "sample") #712

Merged
merged 2 commits into from
Dec 22, 2022
Merged

fix(FEC-12728): Buttons for caption customization do not have descriptive names (they all say, "sample") #712

merged 2 commits into from
Dec 22, 2022

Conversation

Tzipi-kaltura
Copy link
Contributor

Description of the Changes

in "Advanced captions settings" change the button names to Sample 1, Sample 2, Sample 3

solves FEC-12728

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Tzipi-kaltura Tzipi-kaltura merged commit 492dd9d into master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanTGold JonathanTGold JonathanTGold approved these changes

@giladna giladna Awaiting requested review from giladna

@SivanA-Kaltura SivanA-Kaltura Awaiting requested review from SivanA-Kaltura

@ErezKaltura ErezKaltura Awaiting requested review from ErezKaltura

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tzipi-kaltura @JonathanTGold