fix(FEC-12911): keyboard Navigation - Advanced Captions modal #724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
the issue:
current issue is that when navigating to cvaa overlay, the focus should be on the active Sample button, but the focus is actually on a language button element (the globe).
root cause:
this happens because the a11yKeyboard wrapper is triggering unmount for the language smart container, after a11yKeyboard didMount for the cvaa overlay.
solution:
add useEffect to the sample button component to focus to the active element, once mounted.
In addition, did some minor changes to make sampleCaptions component cleaner.
Solves FEC-12911
CheckLists