Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-12972): Remove the volume control on image playback #725

Merged
merged 7 commits into from
Feb 8, 2023
Merged

fix(FEC-12972): Remove the volume control on image playback #725

merged 7 commits into from
Feb 8, 2023

Conversation

JonathanTGold
Copy link
Collaborator

Description of the Changes

Remove the volume control on image playback

fix FEC-12972

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

lianbenjamin
lianbenjamin requested changes Feb 7, 2023
View reviewed changes
src/components/volume/volume.js Outdated Show resolved Hide resolved
giladna
giladna previously approved these changes Feb 7, 2023
View reviewed changes
@JonathanTGold JonathanTGold merged commit 467664d into master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giladna giladna giladna approved these changes

@lianbenjamin lianbenjamin lianbenjamin approved these changes

@SivanA-Kaltura SivanA-Kaltura Awaiting requested review from SivanA-Kaltura

@semarche-kaltura semarche-kaltura Awaiting requested review from semarche-kaltura

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JonathanTGold @giladna @lianbenjamin