fix(FEC-12916): share Plugin Keyboard Functionality #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
lianbenjamin
requested review from
giladna,
JonathanTGold,
semarche-kaltura and
SivanA-Kaltura
SivanA-Kaltura
requested changes
Feb 9, 2023
semarche-kaltura
previously approved these changes
Feb 9, 2023
SivanA-Kaltura
approved these changes
Feb 14, 2023
lianbenjamin
added a commit
to kaltura/playkit-js-share
that referenced
this pull request
Feb 14, 2023
### Description of the Changes related PR- kaltura/playkit-js-ui#727 - disable/enable start from input according to the checkbox - removing onChange handler of start from input; handle the input only when user focus out of the input element. - in case the value in the input start time element is longer than video duration- set the startTime to video length. - allow toggling the start video at checkbox with space keyboard (in addition to Enter) - cover user input cases for start at input element. for example if user sets the start at to "1", format it to "00:01"; if user sets the start at to "67", format it to "01:07" etc. - fix readme file Solves [FEC-12916](https://kaltura.atlassian.net/browse/FEC-12916) ### CheckLists - [ ] changes have been done against master branch, and PR does not conflict - [ ] new unit / functional tests have been added (whenever applicable) - [ ] test are passing in local environment - [ ] Travis tests are passing (or test results are not worse than on master branch :)) - [ ] Docs have been updated [FEC-12916]: https://kaltura.atlassian.net/browse/FEC-12916?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
add functions to time-format.js to support kaltura/playkit-js-share#19
Solves FEC-12916
CheckLists