Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-12934): Add possibility to configure different spinner (loading.js) than the default one #728

Merged
merged 9 commits into from
Feb 13, 2023

Conversation

JonathanTGold
Copy link
Collaborator

@JonathanTGold JonathanTGold commented Feb 9, 2023

Description of the Changes

Add possibility to configure different spinner (which displayed on loading state) than the default on

solves: FEC-12934

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

src/components/loading/loading.js Outdated Show resolved Hide resolved
@JonathanTGold JonathanTGold merged commit 91e1e13 into master Feb 13, 2023
@giladna giladna deleted the FEC-12934 branch April 27, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants