Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-12726): Visual labels that appear on hover need to appear on keyboard focus as well #730

Merged
merged 1 commit into from
Mar 14, 2023
Merged

feat(FEC-12726): Visual labels that appear on hover need to appear on keyboard focus as well #730

merged 1 commit into from
Mar 14, 2023

Conversation

semarche-kaltura
Copy link
Collaborator

@semarche-kaltura semarche-kaltura commented Feb 21, 2023 •
edited by JonathanTGold

Description of the Changes

Displays tooltip when element get focus by keyboard

solves FEC-12726

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@semarche-kaltura semarche-kaltura merged commit c3ee412 into master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SivanA-Kaltura SivanA-Kaltura SivanA-Kaltura approved these changes

@giladna giladna Awaiting requested review from giladna

@JonathanTGold JonathanTGold Awaiting requested review from JonathanTGold

@lianbenjamin lianbenjamin Awaiting requested review from lianbenjamin

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@semarche-kaltura @SivanA-Kaltura