Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-12932): watermark, Logo config - When "Click through URL" is empty new tab is open #731

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

lianbenjamin
Copy link
Collaborator

@lianbenjamin lianbenjamin commented Feb 22, 2023

Description of the Changes

when the (click through) url config of watermark and logo components is empty and clicking on them, a new tab is open with the parent url.
The expected behavior is to make these components unclickable, in case the urls are empty.

  • change the cursor to auto instead of pointer
  • set pointer-events to none to prevent the clicks

Solves FEC-12932

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@lianbenjamin lianbenjamin merged commit a22e780 into master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants